Embedded subexpressions#183
Merged
andyleejordan merged 2 commits intoPowerShell:masterfrom Mar 17, 2021
Merged
Conversation
rename #interpolatedStringContent to subexpression. change subexpression scope to not include 'interpolation'. change scopes for #interpolation to include embedded, keyword.other was punctuation.definition.variable. Change scope for regular `$()`, keyword.other was punctuation.definition.variable. removed redundant includes from #subexpression and #interpolation.
Member
Contributor
Author
rjmholt
approved these changes
Mar 12, 2021
andyleejordan
approved these changes
Mar 17, 2021
Member
|
Thanks @msftrncs! After evaluating the state of the tests, CI, and these three PRs, we went ahead and merged. What's the worst that could happen? 😁 |
Member
|
I know it took a couple years but @msftrncs I wanted to let you know that GitHub Linguist just shipped which includes this and a few of your other fixes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve embedded substatements, fix #132.
#interpolatedStringContentto#subexpression.#interpolationfrom#subexpression.#interpolationto includemeta.embedded,keyword.otherwaspunctuation.definition.variable.$( ),keyword.otherwaspunctuation.definition.variable. (No tests are present for this)#subexpressionand#interpolation.Sample appearance
VS Code (before):
VS Code:
ATOM:
